Skip to content

rename c3 options #8874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 10, 2025
Merged

rename c3 options #8874

merged 4 commits into from
Apr 10, 2025
+17 −8

Conversation

@emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Apr 10, 2025

Fixes DEVX-1782

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: c3
  • Public documentation
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: not a Wrangler change

@emily-shen emily-shen requested a review from a team April 10, 2025 08:49
@emily-shen emily-shen requested a review from a team as a code owner April 10, 2025 08:49
@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: d18ad9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Apr 10, 2025
@workers-devprod workers-devprod added the c3-e2e Run c3 e2e tests on a PR label Apr 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14379300648/npm-package-wrangler-8874

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8874/npm-package-wrangler-8874

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14379300648/npm-package-wrangler-8874 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14379300648/npm-package-cloudflare-workers-bindings-extension-8874 -O ./cloudflare-workers-bindings-extension.0.0.0-vd6384ea0b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vd6384ea0b.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14379300648/npm-package-create-cloudflare-8874 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14379300648/npm-package-cloudflare-kv-asset-handler-8874

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14379300648/npm-package-miniflare-8874

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14379300648/npm-package-cloudflare-pages-shared-8874

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14379300648/npm-package-cloudflare-unenv-preset-8874

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14379300648/npm-package-cloudflare-vite-plugin-8874

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14379300648/npm-package-cloudflare-vitest-pool-workers-8874

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14379300648/npm-package-cloudflare-workers-editor-shared-8874

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14379300648/npm-package-cloudflare-workers-shared-8874

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14379300648/npm-package-cloudflare-workflows-shared-8874

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250408.0
workerd 1.20250409.0 1.20250409.0
workerd --version 1.20250409.0 2025-04-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 10, 2025
@edmundhung edmundhung force-pushed the emily/rename-options branch from b4344e9 to d18ad9f Compare April 10, 2025 11:27
@edmundhung edmundhung merged commit 5ace43b into main Apr 10, 2025
18 checks passed
@edmundhung edmundhung deleted the emily/rename-options branch April 10, 2025 11:49
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 10, 2025
@workers-devprod workers-devprod mentioned this pull request Apr 10, 2025
Merged
@Benz1993com
Copy link

Benz1993com commented Apr 11, 2025

Ok

Benz1993com
Benz1993com reviewed Apr 11, 2025
View reviewed changes
Copy link

@Benz1993com Benz1993com left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@Benz1993com
Copy link

Benz1993com commented Apr 11, 2025

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edmundhung edmundhung edmundhung approved these changes

+1 more reviewer

@Benz1993com Benz1993com Benz1993com left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c3-e2e Run c3 e2e tests on a PR

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emily-shen @Benz1993com @edmundhung @workers-devprod